Skip to content

Implement ZonedDateTime::since and ZonedDateTime::until #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 19, 2025

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 19, 2025

This PR implements the since and until methods for ZonedDateTime.

It also has a host of various bug fixes that I came across from implementing the methods in Boa and running the test suite. As a result, each method has a ~80% conformance rating (since 72/90 and until 70/88).

Copy link
Member

@jasonwilliams jasonwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekevss nekevss merged commit cb10eec into main Jan 19, 2025
6 checks passed
@nekevss nekevss deleted the zdt-until-since branch January 19, 2025 18:17
@jedel1043 jedel1043 added C-enhancement New feature or request C-api Changes related to the public API labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-api Changes related to the public API C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants